Replace per req permit_editable_wheels by a preparer and builder flag#14206
Merged
Merged
Conversation
sbidoul
added
skip news
ichard26
approved these changes
Jul 27, 2026
ichard26
left a comment
ichard26
left a comment
Member
There was a problem hiding this comment.
I was going to refactor this as well, but you beat me to the punch. Many thanks! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14195 reminded me that, back then, I was not happy with the way I implemented this
permit_editable_wheelsper requirement flag.In effect, it is a global mode that allows disabling editable metadata preparation and wheel building and use regular wheels for
pip wheelandpip download. So making it per requirement flag was not a good ift.With this PR I make it a flag on the preparer and propagate it to metadata preparation functions. And an argument to the build function.
This feels cleaner to me and should be more robust.
The two important tests about this still pass (
test_wheel_editable_pep660_basicandtest_download_editable_pep660_basic).