-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Fix extra incorrectly shown on installation error #13659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sepehr-rs
wants to merge
25
commits into
pypa:main
Choose a base branch
from
sepehr-rs:fix-extras
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−6
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0a91572
Remove extras from pip error message when installing packages
sepehr-rs d63cc78
Add news entry
sepehr-rs e9a70e1
Merge branch 'main' into fix-extras
sepehr-rs a771dde
Update 13618.bugfix.rst
sepehr-rs 25bc54b
Merge branch 'main' into fix-extras
sepehr-rs 2c261c3
Move removal of extra down the stack
sepehr-rs 5de2b1a
Fix linting issue
sepehr-rs bbcc416
Merge branch 'main' into fix-extras
sepehr-rs 72535ce
Merge branch 'main' into fix-extras
sepehr-rs a267d13
Merge branch 'main' into fix-extras
sepehr-rs c958efc
Update tests and coverage
sepehr-rs b7437f7
Merge branch 'main' into fix-extras
sepehr-rs 9d0df20
Update code to address reviews
sepehr-rs cd747d0
Merge branch 'main' into fix-extras
sepehr-rs 392b9b0
Update factory.py
sepehr-rs 4299e88
Merge branch 'main' into fix-extras
sepehr-rs 546106e
Update src/pip/_internal/resolution/resolvelib/factory.py
sepehr-rs 08c9cf2
Update package_finder.py
sepehr-rs 07c97b3
Merge branch 'main' into fix-extras
sepehr-rs 3529911
Update src/pip/_internal/resolution/resolvelib/factory.py
sepehr-rs 6fa1d71
Merge branch 'main' into fix-extras
sepehr-rs b3bfb30
Merge branch 'main' into fix-extras
sepehr-rs f342f7e
Merge branch 'main' into fix-extras
sepehr-rs 2b57bdf
Merge branch 'main' into fix-extras
sepehr-rs fd84d17
Merge branch 'main' into fix-extras
sepehr-rs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| When installing packages, pip will no longer show a misleading | ||
| error message that included extra markers such as ``; extra == "..."``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.