Skip to content

Automatically add skip news label to the pull request created by pre-commit ci - #12608

Closed
shenxianpeng wants to merge 4 commits into
pypa:mainfrom
shenxianpeng:add-labeler
Closed

Automatically add skip news label to the pull request created by pre-commit ci#12608
shenxianpeng wants to merge 4 commits into
pypa:mainfrom
shenxianpeng:add-labeler

Conversation

@shenxianpeng

Copy link
Copy Markdown
Contributor

Resolves #12605 (comment)

@uranusjr

uranusjr commented Apr 3, 2024

Copy link
Copy Markdown
Member

Is it possible to check against the author?

@uranusjr

uranusjr commented Apr 3, 2024

Copy link
Copy Markdown
Member

Also this one should use a trivial news file instead.

@shenxianpeng

Copy link
Copy Markdown
Contributor Author

Is it possible to check against the author?

Unfortunately, now it does not support checking author until actions/labeler#563 is merged.

Also this one should use a trivial news file instead.

OK, I've updated to a trivial news file.

@pradyunsg

Copy link
Copy Markdown
Member

I don't think we should be trying to modify the labels, and instead can use github.actor context variable with an if as a part of the run block that invokes towncrier.

https://docs.github.com/en/actions/learn-github-actions/contexts#github-context

@shenxianpeng

Copy link
Copy Markdown
Contributor Author

Thank you @pradyunsg. based on your suggestion, I created #12614 for your review.

@shenxianpeng
shenxianpeng deleted the add-labeler branch April 7, 2024 05:54
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants