fix: take metadata hooks from project - #2351
Merged
Merged
Conversation
flying-sheep
commented
Jul 21, 2026
Comment on lines
-22
to
+24
| self.shell_commands: list[str] = shell_commands or [] | ||
| self.shell_commands: list[str] = list(shell_commands) if shell_commands else [] |
Member
Author
There was a problem hiding this comment.
It’s bad to have cached_propertys that return a mutable value, as you can see here: this line was a bug waiting to happen, as shell_commands gets modified here. Which modifies the cached list in-place, so passing ExecutionContext(..., shell_commands=env_interface.shell_commands) used to modify env_interface in-place.
cjames23
approved these changes
Jul 23, 2026
cjames23
left a comment
cjames23
left a comment
Member
There was a problem hiding this comment.
Thanks for taking this on! And fixing some of the types that I was hoping to get to this week myself!
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
* fix: call hooks from project * fix more types * fix lints * fmt af5339a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2345
I also added type annotations to the file and changed all mutable
cached_propertys to be immutable, see below: