Support bumping static version - #1960
Conversation
|
Gently bumping this as I really would like to see this merged. |
|
Would love to see that in as well, but at this point I already migrated completely to uv as a build system. |
|
Thanks for picking this back up @fabiopicchi, and sorry it sat so long. To be clear up front: the feature itself is something we want (ofek signed off on the concept in #1419), so this is about implementation details, not the idea. A few things need to be addressed before it can merge. 1. It reformats the whole Everywhere else hatch edits TOML it round-trips through a tomlkit document instead. See 2. 3. The backend change is inconsistent. 4. Tests. I know you've since moved to uv, so totally understand if you don't have bandwidth to take this further. Just let me know either way. If you'd rather hand it off, I'm happy to carry it forward from here. Appreciate the work getting it this far. This comment was AI assisted with Claude Code using Opus 4.8 |
|
Hi @cjames23, thanks for the comprehensive feedback. Happy to work on it this week (I will have more time towards the end of it) 🙂 I moved to uv professionally, but I think it is really important that the default python tools are as useful and convenient as we can get them to be! Thanks for your valuable work. |
abeea43 to
579f95c
Compare
|
@cjames23 can we add I was considering a regex-based approach (maybe even for I had a quick look at the PEP, and it seems that the Also, please let me know if the changes I made so far are good or not in terms of quality/style :) |
a9642dc to
fea3f7c
Compare
|
I think tomlkit is an acceptable dependency for hatchling if it is needed |
|
@cjames23 at first I thought of implementing this exclusively in hatchling and reuse it from hatch, but I guess a little copying is better than a little coupling in this case (the implementations are similar but not exactly the same). I couldn't find tests for the version cli in hatchling, where should I add them? Glad to work on any additional changes if needed. |
Solves #1419