Fix hardcoded reliance on pip - #1882
Conversation
56d4787 to
b1838f8
Compare
Address: juftin/hatch-pip-compile#85 # Conflicts: # src/hatch/cli/application.py
Switch from --directory to --python switch to simplify `uv pip install` command.
8dca06c to
c1f2e75
Compare
|
@ofek would you please re-approve workflows once again, I fixed formatting errors reported. I am really sorry to bother you. 😔 |
|
Not sure why 3.12 on Linux failed. Re-run that in my repo and it passed. 🤷 |
|
Tests fail due to differences in rendering hatch/tests/cli/python/test_show.py Lines 18 to 19 in 9068758 The following update in with console.capture() as capture:
console.print(table, overflow="ignore", no_wrap=True, crop=False) |
ofek
left a comment
There was a problem hiding this comment.
Thanks for your patience here!
|
I wanted to follow up on this pull request. I have addressed a while ago the feedback from the previous review, and the changes should be good to go. I know you all are incredibly busy, but whenever you have some time to take a look, I would really appreciate it. Thanks again for your time and dedication to the project! |
|
I will work on getting the type issue fixed so we can check the tests here |
|
@cjames23 please let me know if I can help you with that. |
This is an attempt to fix the issue described here juftin/hatch-pip-compile#85.
As it was discussed there, since
hatchalready depends onuvthere is no need to rely onpipinstall during environment requirements resolution, because it may be not available.