Skip to content

Fix hardcoded reliance on pip - #1882

Merged
cjames23 merged 51 commits into
pypa:masterfrom
vpetrigo:fix/hardcoded-reliance-on-pip
Jul 23, 2026
Merged

Fix hardcoded reliance on pip#1882
cjames23 merged 51 commits into
pypa:masterfrom
vpetrigo:fix/hardcoded-reliance-on-pip

Conversation

@vpetrigo

@vpetrigo vpetrigo commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

This is an attempt to fix the issue described here juftin/hatch-pip-compile#85.

As it was discussed there, since hatch already depends on uv there is no need to rely on pip install during environment requirements resolution, because it may be not available.

Comment thread src/hatch/cli/application.py Outdated
Comment thread src/hatch/cli/application.py
Comment thread src/hatch/cli/application.py
@vpetrigo
vpetrigo force-pushed the fix/hardcoded-reliance-on-pip branch from 56d4787 to b1838f8 Compare January 11, 2025 22:04
@vpetrigo
vpetrigo force-pushed the fix/hardcoded-reliance-on-pip branch from 8dca06c to c1f2e75 Compare July 2, 2025 14:18
@vpetrigo

Copy link
Copy Markdown
Contributor Author

@ofek would you please re-approve workflows once again, I fixed formatting errors reported. I am really sorry to bother you. 😔

@vpetrigo

Copy link
Copy Markdown
Contributor Author

Not sure why 3.12 on Linux failed. Re-run that in my repo and it passed. 🤷

@vpetrigo

vpetrigo commented Jan 29, 2026

Copy link
Copy Markdown
Contributor Author

Tests fail due to differences in rendering Terminal output:

with console.capture() as capture:
console.print(table)

The following update in test_show.py fixes tests:

    with console.capture() as capture:
        console.print(table, overflow="ignore", no_wrap=True, crop=False)

@ofek ofek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience here!

Comment thread src/hatch/cli/application.py Outdated
@vpetrigo
vpetrigo requested a review from ofek March 9, 2026 09:54
@vpetrigo

vpetrigo commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Hi @ofek @cjames23,

I wanted to follow up on this pull request. I have addressed a while ago the feedback from the previous review, and the changes should be good to go. I know you all are incredibly busy, but whenever you have some time to take a look, I would really appreciate it.

Thanks again for your time and dedication to the project!

@cjames23

Copy link
Copy Markdown
Member

I will work on getting the type issue fixed so we can check the tests here

@vpetrigo

Copy link
Copy Markdown
Contributor Author

@cjames23 please let me know if I can help you with that.

@cjames23
cjames23 merged commit b1af6e8 into pypa:master Jul 23, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants