Remove building from url, pypi, requirements features#362
Conversation
agriyakhetarpal
left a comment
There was a problem hiding this comment.
I am +1 on this change, but we might want to think about this. We are still going to have some packages that retain patches, and removing them may cause regressions for users and towards our adoption, as was the case with the disabled packages landing in 0.28. Is there a way for us to estimate the impact? I don't think many people were using these features, as you mentioned, but it might still be good to do a sanity check by making this softer: deprecate with a notice in one release, then remove in the next?
I haven't had much of a use for these features before, so just to clarify, our feature to do nothing and just download the wheel if a wheel URL is specified in the recipe file is not going away here, and these are all just pyodide build features, not pyodide build-recipes features?
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Oops, I meant to approve this alongside my question, not comment.
|
Yeah, this does not affect |
|
Makes sense! I added this label, inspired by cibuildwheel, so that we will remember. |
I would like to remove these features to reduce our maintenance burden. These features were requested and added by @joemarshall as a workaround before PEP 783 is accepted, so that people can build a set of packages that they want to use.
However, as pyodide wheels can be uploaded into PyPI, I don't want to maintain this feature. Instead, users should reach out to the package maintainers to build and upload wheels to PyPI.