Skip to content

Remove building from url, pypi, requirements features#362

Open
ryanking13 wants to merge 2 commits into
pyodide:mainfrom
ryanking13:remove-resovle
Open

Remove building from url, pypi, requirements features#362
ryanking13 wants to merge 2 commits into
pyodide:mainfrom
ryanking13:remove-resovle

Conversation

@ryanking13

Copy link
Copy Markdown
Member

I would like to remove these features to reduce our maintenance burden. These features were requested and added by @joemarshall as a workaround before PEP 783 is accepted, so that people can build a set of packages that they want to use.

However, as pyodide wheels can be uploaded into PyPI, I don't want to maintain this feature. Instead, users should reach out to the package maintainers to build and upload wheels to PyPI.

@agriyakhetarpal agriyakhetarpal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am +1 on this change, but we might want to think about this. We are still going to have some packages that retain patches, and removing them may cause regressions for users and towards our adoption, as was the case with the disabled packages landing in 0.28. Is there a way for us to estimate the impact? I don't think many people were using these features, as you mentioned, but it might still be good to do a sanity check by making this softer: deprecate with a notice in one release, then remove in the next?

I haven't had much of a use for these features before, so just to clarify, our feature to do nothing and just download the wheel if a wheel URL is specified in the recipe file is not going away here, and these are all just pyodide build features, not pyodide build-recipes features?

@agriyakhetarpal agriyakhetarpal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I meant to approve this alongside my question, not comment.

@ryanking13

Copy link
Copy Markdown
Member Author

Yeah, this does not affectpyodide build-recipes, only affect pyodide build. There is no reason to hurry, so we can wait for 314.0.0 release, start poking people to upload pyemscripten wheels, and then we can merge this PR.

@agriyakhetarpal agriyakhetarpal added the hold for future release This item should not make it to the next planned release label Jun 6, 2026
@agriyakhetarpal

Copy link
Copy Markdown
Member

Makes sense! I added this label, inspired by cibuildwheel, so that we will remember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold for future release This item should not make it to the next planned release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants