Skip encrypted pdfs#431
Open
JorjMcKie wants to merge 2 commits into
Open
Conversation
According to benchmark results, this change will have a negligible effect on OCR quality. On the upside are significantly reduced runtime memory loads and a roughly doubled execution speed.
Add a new "password" parameter and authenticate PDFs with it. Raise exception if authentication fails.
JorjMcKie
force-pushed
the
skip-encrypted-pdfs
branch
from
b2ae60d to
990985f
Compare
julian-smith-artifex-com
left a comment
julian-smith-artifex-com
left a comment
Collaborator
There was a problem hiding this comment.
Could we put password-checking somewhere more central so that we don't need 6 separate call sites of verify_password()?
Comment on lines
+70
to
+80
| def verify_password(doc: pymupdf.Document, password: str) -> bool: | ||
| """Verify password correctness for a PDF document. Returns True if the password is correct or not needed, False otherwise.""" | ||
| if not doc.is_pdf or not doc.needs_pass: | ||
| return True # Not a PDF or no password required | ||
| if not password or not (isinstance(password, str) and len(password) < 40): | ||
| # Password required but is missing or invalid | ||
| return False | ||
| rc = doc.authenticate(password) | ||
| if not rc: | ||
| return False # Incorrect password | ||
| return True |
Collaborator
There was a problem hiding this comment.
All 6 calls of this new function raise an exception if it returns false.
Could we instead make this fn raise an exception itself? This would simplify calling code.
It would also allow us to give a more useful exception message - it think it would be useful for users to distinguish the separate failure modes:
- no password specified.
- password too long.
- incorrect password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.