Fix: small glyph line grouping issue#391
Open
marca116 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
helpers/get_text_lines.py::get_raw_lines, spans are grouped into lines by checking whether their top or bottom y-coordinate aligns withintolerance(default 3). This fails for glyphs that have a small, accurate bbox sitting vertically centered inside the full-height text, like a dash, period, or asterisk. Neither edge of the small bbox aligns with the surrounding text, so the glyph gets treated as a different line and ends up reordered.The issue occurs with
tests/test_370.pdf.Expected:
Actual (before this PR):
The dash gets pulled off
g-and stuck at the start of the paragraph.Fix
Added a containment check alongside the existing edge-alignment checks: if the previous span's vertical extent fits inside the current span's (within
tolerance), they belong on the same line.Test
Added
test_370_small_glyph_line_assignmentintests/test_370.py, which asserts the dash stays attached tog-and does not get reordered to the start of the paragraph.