LLM code smells refactoring

[Raposones]

For easier code understaing, i refactored the following code smells:

• too-many-statements
• too-many-instance-attributes
• too-many-branches

All code smells were found by Pylint and refactored by LLM model DeepSeek V4 Flash Free via OpenCode desktop application.

[github-actions]

👋 Welcome to CausalPy, @Raposones!

Thank you for opening your first pull request! We're excited to have you contribute to the project. 🎉

Here are a few tips to help your PR get merged smoothly:

• ✅ Make sure all CI checks pass (tests, linting, type checking)
• 📝 Run prek run --all-files locally before pushing
• 📖 Check our Contributing Guide for more details

A maintainer will review your changes soon. Thanks for helping make CausalPy better! 🚀

---

💼 LinkedIn Shoutout: Once your PR is merged, we'd love to give you a shoutout on LinkedIn to thank you for your contribution! If you're interested, just drop your LinkedIn profile URL in a comment below.

[read-the-docs-community]

Documentation build overview

📚 causalpy | 🛠️ Build #33242881 | 📁 Comparing 6ff881b against latest (2c7ec49)

  🔍 Preview build  

41 files changed · + 3 added · ± 38 modified

+ Added

• api/generated/causalpy.checks.placebo_in_time.AssuranceConfig.html
• api/generated/causalpy.checks.placebo_in_time.ConfusionRates.html
• api/generated/causalpy.checks.placebo_in_time.FoldSelectionConfig.html

± Modified

• 404.html
• genindex.html
• _modules/causalpy/pymc_models.html
• api/generated/causalpy.checks.placebo_in_time.AssuranceResult.html
• api/generated/causalpy.checks.placebo_in_time.html
• api/generated/causalpy.experiments.diff_in_diff.DifferenceInDifferences.html
• api/generated/causalpy.experiments.instrumental_variable.InstrumentalVariable.html
• api/generated/causalpy.experiments.instrumental_variable.InstrumentalVariable.plot.html
• api/generated/causalpy.experiments.interrupted_time_series.InterruptedTimeSeries.html
• api/generated/causalpy.experiments.inverse_propensity_weighting.InversePropensityWeighting.html
• and 28 more...

[drbenvincent]

Hi @Raposones, thanks for diving in. The smells you're pointing at are genuinely there.

I'm going to close this one, and I want to explain why so it's useful rather than discouraging:

It overlaps an in-flight refactor. #966 is an open PR that restructures these same experiment classes, including the too-many-instance-attributes god-object problem this PR targets. Two large refactors over the same files can't both land. Our contributing guide asks contributors to check open PRs for overlap before starting — that's the step that would've caught this.

Scope + method. A 5,500-line LLM-generated rewrite touching 21 core files is more than we can responsibly review or verify line-by-line. Our guide is explicit that agent-generated code is welcome, but not code the author hasn't personally vetted. Re-writing tests is a big no-no on a massive refactor - the tests ensure unchanged behaviour, so that should be separate.

No agreed approach. For changes this structural we settle the design in an issue first, so effort isn't spent on an approach that conflicts with the direction the maintainers are already taking.

None of this means don't contribute - we'd genuinely welcome you. The best on-ramp: pick an existing issue, maybe one tagged as 'good first issue'. If you want, comment on an existing issue or open one describing the cleanup you'd like to tackle and we'll point you at something that won't collide with current work. Thanks again for the interest, hope to see something in the future.