Propagate triangularity through matrix transpose#2174
Merged
jessegrabowski merged 2 commits intoMay 30, 2026
Conversation
Replace the dead _dimshuffle_left_expand_dims rule (shadowed by the default DimShuffle handler) with cross-key inference: a matrix-transpose DimShuffle now flips lower<->upper, so downstream rewrites can see triangular structure through .T / .mT.
ricardoV94
approved these changes
May 27, 2026
Member
ricardoV94
left a comment
ricardoV94
left a comment
There was a problem hiding this comment.
A bit more work but you can propagate False if the input triangularity is false (not just unknown)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following was not being correctly propagated:
This was just an oversight, so I added it.