Add lossless JsonValue float mode#252
Draft
brycedrennan wants to merge 1 commit into
Draft
Conversation
Merging this PR will improve performance by 11.5%
Performance Changes
Tip Curious why this is faster? Comment Comparing 
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
brycedrennan
changed the title
brycedrennan
force-pushed
the
codex/lossless-jsonvalue-floats
branch
5 times, most recently
from
166f5eb to
611b035
Compare
brycedrennan
force-pushed
the
codex/lossless-jsonvalue-floats
branch
from
611b035 to
0f1a3a8
Compare
Author
|
@codspeedbot explain why this is faster |
|
It looks like you haven't signed up on CodSpeed yet. Please visit codspeed.io to create an account, then try again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in
JsonValueFloatMode::LosslessFloatmode that preserves non-integer JSON numbers asJsonValue::LosslessFloat(Cow<str>)instead of forcing them throughf64.Default parsing stays unchanged.
Intended to allow deserialization of numbers of arbitrary precision.
Addresses #230
After merging I'll open an integration pull request into pydantic.