fix: disallow QQuantity with derived units#342
Merged
Conversation
This will make testing unit choices easier by decoupling the logic from the gui
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
==========================================
+ Coverage 84.81% 84.85% +0.04%
==========================================
Files 49 49
Lines 3904 3909 +5
==========================================
+ Hits 3311 3317 +6
+ Misses 593 592 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tlambert03
reviewed
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #339.
Added:
1/s,m^2) are supportedNotImplementedErrorwhen using non-simple units (m/s,N).There is probably a world where it wouldn't be too hard to infer the prefixes if it's a single unit like
N, but I'm not tackling that right now.I have also updated the docs and added corresponding tests.