Skip to content
This repository was archived by the owner on Oct 13, 2021. It is now read-only.

Provide kustomize v2 compatible descriptors#130

Open
looztra wants to merge 1 commit into
pusher:masterfrom
looztra:fix_config_for_kustomize2
Open

Provide kustomize v2 compatible descriptors#130
looztra wants to merge 1 commit into
pusher:masterfrom
looztra:fix_config_for_kustomize2

Conversation

@looztra

@looztra looztra commented Apr 6, 2019

Copy link
Copy Markdown

@pusher-ci

Copy link
Copy Markdown

Hi @looztra. Thanks for your PR.

I'm waiting for a pusher member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mthssdrbrg

Copy link
Copy Markdown
Contributor

Thanks for the PR!

I had a browse through the kubebuilder repository and found this PR which updates the scaffolding to work with kustomize v2. If you could update this PR to match that structure I'd be happy to merge it.

/ok-to-test

@pusher-ci

Copy link
Copy Markdown

@looztra: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-faros-test-1.12 6cfcda1 link /test 1.12

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@looztra

looztra commented Apr 11, 2019

Copy link
Copy Markdown
Author

Not sure to understand what you want. That the changes that I propose should be compatible with what a newer version of kubebuilder (compared to what was used in the past?) would produce?

@pusher-ci

Copy link
Copy Markdown

@looztra: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

4 participants