fix: check cgroup file readability to prevent warning on android#419
Open
geoffsym wants to merge 1 commit into
Open
fix: check cgroup file readability to prevent warning on android#419geoffsym wants to merge 1 commit into
geoffsym wants to merge 1 commit into
Conversation
geoffsym
commented
Jun 8, 2026
| --argument-names cgroup_namespace | ||
| set --query cgroup_namespace[1]; or set cgroup_namespace /proc/1/cgroup | ||
|
|
||
| test -r $cgroup_namespace; or return 1 |
Author
There was a problem hiding this comment.
The code conventions say to use long form options, but test lacks any long form options
Member
There was a problem hiding this comment.
Hello @geoffsym,
Thanks for the contribution!
Mentioning android raised our eyebrows. We didn't expect people to use pure on mobile.
it will be preferable to disable the detection feature than to mute the warning in the project.
set --universal pure_enable_container_detection false
Convention
The long option rule is not applicable here
Member
|
Is this PR still relevant? N.B.: In the absence of reply a month after this message, I will close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following error message on every prompt in the Termux Android app (and presumably other non-standard Linux environments):
How to test pre-release?
Acceptance Checks