fix Credential.getAccessToken (returns a promise)#63
Open
alextekartik wants to merge 34 commits into
Open
Conversation
Null safety
Null safety
[firestore_node] feat: add support for whereIn
dart2_3
dart2_3
dart2_3
dart3a branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated here:
https://firebase.google.com/docs/reference/admin/node/admin.credential.Credential-1#getaccesstoken
getAccessTokenreturns a Promise. I changed the implementation and added a simple unit test (the change in firestore_test.dart is just a formatting change that was done automatically).I have not setup any dart high level wrapper on Credential as I'm not sure how you would prefer it.