[ci] Add slang lint by micprog · Pull Request #445 · pulp-platform/ara

micprog · 2026-04-10T09:42:59Z

No description provided.

PR review (hopang-0221): the automatic variables introduced to silence slang's -Winferred-latch are not visible in waveforms, since they do not exist as named signals in the design hierarchy. Restore them as module-scope signals and break the inferred latches with unconditional default assignments at the top of their always_comb blocks instead. No functional change: each of these is always assigned before it is read on the path that uses it, so the defaults only affect the otherwise-unread latch paths. Affected: simd_alu (r), lane_sequencer (extra_stride/vl_tot), masku (vrgat_res/vrgat_buf), vldu (vrf_word_start_byte), vstu (vrf_eff_write_bytes), vmfpu (vfrec7/vfrsqrt7 scratch arrays, narrowing_shuffled_result/narrowing_shuffle_be). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

PR review (hopang-0221): unlike VSSUBU, the VSSUB saturation flag is not replicated across all bits of vxsat.w{16,32,64}[b] (only the LSB is set), so the AND-reduction introduced for the slang -Wint-bool-conv fix is always 0 and saturation never triggers. Use OR-reduction instead, which matches the original non-zero test and clears the warning. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

PR review (hopang-0221): replace the verbose explicit zero-pad replications (added to avoid an unsized '0 inside a concatenation) with equivalent implicit zero-extension and a plain literal comparison. out_pnt_d is wide enough to hold {red_stride_cnt_d, 3'b0}, and the popc compare is against the value 1 - no functional change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

micprog · 2026-06-02T10:04:30Z

Thanks for the review @hopang-0221! I addressed the issues you raised and rebased on main. The slang action has a small issue as it was constructed without accounting for newer slang versions breaking the API, pulp-platform/pulp-actions#29 should address that.

hopang-0221 · 2026-06-02T16:45:44Z

I think this also changes the functionality:
old: res.w8 [2b + narrowing_select_i] = ($signed(opb.w16[b]) >>> opa.w16[b][3:0]) + rm[b];
new: res.w8 [2b + narrowing_select_i] = $unsigned(($signed(opb.w16[b]) >>> opa.w16[b][3:0]) + $signed(rm[b]));

rm[b] is 1-bit number:

Without $signed(), rm[b]==0 -> 0; rm[b]==1 -> 1

With $signed(), rm[b]==0 -> 0; rm[b]==1 -> -1

micprog force-pushed the slang-action branch from 31b6cf2 to 5184b1a Compare April 10, 2026 16:03

micprog requested review from Navaneeth-KunhiPurayil and hopang-0221 April 10, 2026 16:03

micprog marked this pull request as ready for review April 11, 2026 15:05