Add more async lifecycle tests and fix potential POSIX cancellation fd leak#93
Open
puddly wants to merge 14 commits into
Open
Add more async lifecycle tests and fix potential POSIX cancellation fd leak#93puddly wants to merge 14 commits into
puddly wants to merge 14 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #93 +/- ##
==========================================
+ Coverage 91.46% 92.21% +0.74%
==========================================
Files 22 22
Lines 3599 3621 +22
==========================================
+ Hits 3292 3339 +47
+ Misses 307 282 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an explicit test suite for the
asyncio.Protocolstate machine pattern and aligns platform behavior around poorly-timed cancellation. These aren't things normally hit at runtime often but it's not good practice to leak file descriptors, especially when we useflock.We also plug a few more cancellation point leaks. This pattern is a bit annoying to deal with because any
awaitpoint can potentially be cancelled but with the asterisk that we are often awaiting on the result of a thread pool executor, which cannot be cancelled. This requires a bit of coordination with future callbacks and such.For Windows, we now intentionally detach the file handle from
PyHANDLEand let it "leak" for consistency with POSIX, since the cleanup code should work without a magical__del__.