disable "nobody's around" message #108

[pdurbin]

I've described in #108 how plotbot always insists on getting the last word. In this pull request I'm attempting to disable the "nobody's around" message. We can rethink this feature in the future.

[coveralls]

Coverage remained the same at 94.118% when pulling 16f9e7b on pdurbin:108-disable-nobodys-around into d87ef5d on publiclab:master.

[coveralls]

Coverage remained the same at 94.118% when pulling 16f9e7b on pdurbin:108-disable-nobodys-around into d87ef5d on publiclab:master.

[jywarren]

Thanks, I agree -- i think it's causing disruption currently, and until we can resolve with something like #109 we need to put a hold on this behavior.

Would this result in plotsbot sending an empty string message somehow? Could we instead comment out this line?

plotsbot/src/bot.js

Line 18 in d87ef5d

const unresponsiveBehavior = require('./behaviors/unresponsive')(state);

and then comment out the corresponding test entirely for the time being? Some test frameworks allow for things like xtest() to "turn off" a test instead of commenting it out. But since this is a stopgap, i think we could just comment out the whole thing.

[pdurbin]

Would this result in plotsbot sending an empty string message somehow?

@jywarren sorry, I should have mentioned that I tested it. No, an empty string isn't sent. Nothing is sent. Silence is golden.

[ryzokuken]

LGTM until we figure out a better solution.

[jywarren]

@icarito could we deploy this, or does it deploy automatically now? I see motion at https://jenkins.laboratoriopublico.org/ ... cool!

[icarito]

Yup it's automatic. :-)

…

On 01/05/18 17:56, Jeffrey Warren wrote: @icarito <https://github.com/icarito> could we deploy this, or does it deploy automatically now? I see motion at https://jenkins.laboratoriopublico.org/ ... cool! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#110 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMMS9f8gkV9PKmjSbTWFly70hgH0k28ks5tuOgogaJpZM4Ttbhq>.

[pdurbin]

Nice! Thanks, all!