Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR customizes JSON serialization formatting, updates the VS Code debug task name, and cleans up the GitHub Actions workflow.
- Adds a
NewLinesetting toJsonOptions - Changes the VS Code
preLaunchTaskfrom.NET Buildto.Net Build - Removes the outdated
labelsfield from the update-languagedata workflow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| LanguageTags/JsonOptions.cs | Add NewLine = "\r\n" to JsonSerializerOptions |
| .vscode/launch.json | Update preLaunchTask label casing |
| .github/workflows/update-languagedata.yml | Remove labels: 'update-languagedata' |
Comments suppressed due to low confidence (2)
LanguageTags/JsonOptions.cs:22
- JsonSerializerOptions does not have a
NewLineproperty, causing a compilation error. Consider removing this initializer or configuring line endings through a customUtf8JsonWriterOptionswhen writing JSON.
NewLine = "\r\n",
.vscode/launch.json:8
- The
preLaunchTaskvalue.Net Buildlikely doesn't match the actual task label (usually.NET Build), which will prevent the build from running before launch. Update it to exactly match the task name defined intasks.json.
"preLaunchTask": ".Net Build",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.