feat(meshcore): log DESIRED vs READBACK after channel apply#131
Merged
Conversation
After apply_mc_channel_config, read the device without scope_hints and warn on name/type mismatches so operators do not treat scope_hints merge as firmware truth. Closes #129.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_mc_channel_config, log the apply payload as DESIRED and a device readback as READBACK (viaread_device_channelswithoutscope_hints).region_scopeonly when firmware returns scope inCHANNEL_INFO(expected to be absent today).scope_hintsand is not proof of per-slot scope on the radio (#129).Closes #129
Testing performed
pytest test/meshcore/test_channels.py test/meshcore/test_channel_sync.py -v --no-cov