feat(meshcore): sync and apply region_scope (#391)#127
Merged
Conversation
Include region_scope in mc-channel-sync snapshots (null when companion omits it). Best-effort set_flood_scope on apply when meshcore_py supports it.
Overlay apply payload scope onto device read before mc-channel-sync when CHANNEL_INFO omits per-channel scope; pass scope_hints through sync paths.
This was referenced Jun 3, 2026
schedule_channel_sync passes scope_hints to sync_channels_to_storage_apis_async; update radio channel sync regression tests to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
region_scopeinmc-channel-syncsnapshot entries (nullwhen companionCHANNEL_INFOomits scope).set_flood_scopeper channel row (active flood scope on companion; last slot wins until operator changes channel in MeshCore app).region_scopefrom the apply payload onto device read bymc_channel_idxbefore posting sync (scope_hints), so the API does not create duplicate unscoped rows.log_device_channelsalways logs scope (or(none)).Depends on meshflow-api #393 (merge API + migrate first).
Related: meshflow-api #393, meshflow-ui #321
Testing performed
pytest test/meshcore/test_channels.py test/test_bot.py