fix(meshcore): schedule channel sync from WS worker thread (#91)#125
Merged
Conversation
apply_mc_channel_config runs on asyncio.to_thread; post-apply schedule_channel_sync used create_task without a running loop. Submit sync coroutines via run_coroutine_threadsafe when off-loop. Closes #91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_mc_channel_configfailing after writing channels to the device withno running event loop.on_apply_mc_channel_configruns on a WebSocket worker thread (asyncio.to_thread); post-applyschedule_channel_syncincorrectly calledasyncio.create_taskon that thread._submit_coro_to_radio_loopto usecreate_taskon the MeshCore loop thread orrun_coroutine_threadsafefrom other threads.Related
Testing performed
pytest test/meshcore/test_radio_channel_sync.py -v --no-cov