fix(ws): include protocol on text message WebSocket payload (#279)#397
Merged
Conversation
Add text-messages feature hub and unread-count deep dive; note TextMessageWSSerializer missing protocol field.
Add protocol to TextMessageWSSerializer matching REST labels. Tests in ws/tests/test_text_message_ws_serializer.py.
Helps meshflow-ui infer MeshCore when protocol is missing on older payloads.
This was referenced Jun 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
protocol(meshtastic/meshcore) toTextMessageWSSerializerso WebSocket pushes match REST/OpenAPI and meshflow-ui can scope unread badges correctly.Related: meshflow-ui#279 — UI PR will follow and should deploy together.
Testing performed
python -m pytest Meshflow/ws/tests/test_text_message_ws_serializer.py -vws/