feat(meshcore): enrich heard resolved_path with segment lookup and auto-matcher#395
Merged
Merged
Conversation
…to-matcher Key heard[] hops by hash_mode, hash_size, and segment_hash; add short_name, candidates on ambiguous suffix matches, and path_hash metadata on observations.
Record tier-1/tier-2 PR status, GI7ULG pre-prod findings, and heard sender UX fix; clarify empty path_hashes vs resolution gaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
heard[]path hop resolution by(hash_mode, hash_size, segment_hash)when loadingMeshCorePathSegmentResolutionrows.path_hash_modeandpath_hash_sizeon eachMeshCoreHeardObservation.resolvedwithshort_nameand position; multiple →ambiguouswithcandidates[].ResolvedHopand traceroute ADR addendum.Testing performed
pytest meshcore_packets/tests/test_path_resolution.py text_messages/tests/test_heard_api.pyheard[].resolved_pathon pre-prod (e.g. GI7ULG test message)Deploy before meshflow-ui#322.
Related: meshflow-ui#311