feat(meshcore): admin region_scope display and scope investigation docs (#129)#394
Merged
Conversation
Add scope column and list filter on MeshCore channels admin; show scope in managed node device mirror table with mirror labels that omit scope suffix.
Add bug-channel-scope-read-write (meshflow-bot#129) and bug-no-path-info; link from mc-channel-sync and packet-path-tracing READMEs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
region_scopecolumn and list filter (null / has scope / per-scope) on MeshCore channels; scope column on Managed Node feeder mirror table (mc_channel_mirror_labelavoids duplicating scope in the label).bug-no-path-infodoc and README links.Related bot work: meshflow-bot#129, meshflow-bot#130.
Test plan
pytest Meshflow/common/tests/test_mc_channel_labels.py