-
Notifications
You must be signed in to change notification settings - Fork 0
feat(platform): cut over macOS listener inspection #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d2c97f0
docs(platform): support macOS 14 and newer
munezaclovis 9358d51
feat(platform): cut over macOS listener inspection
munezaclovis 04171ae
ci: run full macOS support matrix
munezaclovis fc2090e
test(platform): run listener acceptance in full matrix
munezaclovis c4f8804
test(cli): make PHP fixtures platform deterministic
munezaclovis 8efbfe2
test(daemon): report Mailpit fixture failures
munezaclovis eb752a8
test(daemon): attach Mailpit logs to errors
munezaclovis b55cccf
test(daemon): avoid threaded Mailpit HTTP fixtures
munezaclovis f9040de
test(daemon): trace Mailpit fixture lifecycle
munezaclovis 66a4c75
test(daemon): avoid fixture FQDN lookups
munezaclovis 872e229
test(release): avoid RustFS fixture FQDN lookup
munezaclovis 67bfd78
test(cli): block accepted fake daemon streams
munezaclovis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 9 additions & 3 deletions
12
crates/daemon/test-fixtures/gateway/fake-frankenphp-hangs-on-port-server.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,18 @@ | ||
| #!/usr/bin/env python3 | ||
| import http.server | ||
| import signal | ||
| import socketserver | ||
| import sys | ||
|
|
||
|
|
||
| class Server(http.server.ThreadingHTTPServer): | ||
| def server_bind(self): | ||
| # Avoid HTTPServer's unnecessary FQDN lookup for a loopback fixture. | ||
| socketserver.TCPServer.server_bind(self) | ||
| self.server_name, self.server_port = self.server_address[:2] | ||
|
|
||
|
|
||
| signal.signal(signal.SIGUSR1, signal.SIG_IGN) | ||
| port = int(sys.argv[1]) | ||
| with http.server.ThreadingHTTPServer( | ||
| ("127.0.0.1", port), http.server.SimpleHTTPRequestHandler | ||
| ) as server: | ||
| with Server(("127.0.0.1", port), http.server.SimpleHTTPRequestHandler) as server: | ||
| server.serve_forever() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the newly added macOS 26 lane runs
cargo nextest run --workspace --all-features --locked, this commit's own validation reports three Mailpit HTTP-readiness timeouts on that host. The fixture changes in this diff only add stderr diagnostics and error context—and still useThreadingHTTPServer—so they do not resolve the reported failures; enabling this required lane therefore leaves PR and push CI red whenever those timeouts reproduce. Stabilize the affected tests before requiring this lane, or temporarily isolate the failing coverage.Useful? React with 👍 / 👎.