refactor: simplify image builds - #28
Draft
munezaclovis wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlsrv/pdo_sqlsrvand currentsvgowiphelper and redundantxwrapperWhy
The existing update path required changing versions and checksums throughout the Dockerfile even when only an upstream patch release changed. This keeps intentional compatibility boundaries (PHP/Node/pnpm/Composer major or minor channels and the Debian variants) while allowing routine upstream updates to flow through scheduled builds.
This is the consolidated follow-up to the pinning discussion in #27.
Tag impact
Exact PHP patch tags are no longer generated. Published tags track the supported PHP minor (
php8.4,php8.5) plus the existing latest, PHP-major, Debian, and development aliases.Validation
docker build --pull --build-arg VERSION=8.5-trixie --target dev -t frankenphp:simplified-dev .docker run --rm -v "$PWD/test.php:/test.php:ro" frankenphp:simplified-dev php /test.php devdocker run --rm frankenphp:simplified-dev zsh -i -c 'echo dev-shell-ok'docker build --pull --build-arg VERSION=8.5-trixie --target prod -t frankenphp:simplified-prod .docker run --rm -v "$PWD/test.php:/test.php:ro" frankenphp:simplified-prod php /test.php productiondocker build --pull --build-arg VERSION=8.4-bookworm --target prod -t frankenphp:simplified-bookworm-prod .docker run --rm -v "$PWD/test.php:/test.php:ro" frankenphp:simplified-bookworm-prod php /test.php productiondocker buildx bake --printdocker build --check --build-arg VERSION=8.5-trixie --target dev .actionlint .github/workflows/pipeline.ymlzsh -n .zshrc .zshrc.prodphp -l test.phpgit diff --checkAll local checks passed on arm64; the PR workflow covers both supported architectures.