Fix/cell value formatting#3
Open
rubensayshi wants to merge 2 commits into
Open
Conversation
Replace buggy yymmdd dependency with own Excel-to-Go date format converter that correctly handles context-dependent m/mm token (month vs minutes). Add format detection heuristics (isDateFormat, isNumberFormat), built-in date format handling (14-58), built-in number format handling (1-13). Add XLS-vs-XLSX comparison tool. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cherry-pick of error propagation refactor. All binary.Read, Seek, and get_string errors now propagate to callers. Public API changes: Parse() returns error, GetSheet() returns (*WorkSheet, error), ReadAllCells() returns ([][]string, error). Treats EOF/UnexpectedEOF in record body reads as benign (EOF marker). HYPERLINK text mark errors are non-fatal. Preserves samy-fixes defensive guards (count==0, b.Size<20, nil format map init). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.