feat: add favourites module (closes #8)#9
Merged
Conversation
Implements issue #8. Users can favourite chess players, F1 drivers, F1 constructors, and football leagues. The show command fetches live data for all saved favourites and renders a per-category Rich dashboard. Adds three config helpers (get_favourites, add_favourite, remove_favourite), registers the fav sub-app in the CLI root, and covers 36 new tests (277 total). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sports favsub-command with four commands:add,remove,list,showsports fav showfetches live data for all saved favourites and renders a per-category Rich dashboard — no API key needed for chess and F1, football key reused from config~/.config/sportscli/config.jsonunder a"favourites"key; duplicates are silently ignoredTest plan
pytest— 277/277 passing locallypython-package.ymlsports fav add chess magnuscarlsen→sports fav showsports fav add f1-driver verstappen→sports fav showsports fav list,sports fav remove chess magnuscarlsen🤖 Generated with Claude Code