fix(product): ask the brownfield question even in unattended runs#143
Draft
AlexanderMakarov wants to merge 1 commit into
Draft
fix(product): ask the brownfield question even in unattended runs#143AlexanderMakarov wants to merge 1 commit into
AlexanderMakarov wants to merge 1 commit into
Conversation
The silent-prompt brownfield branch ended with "This question is reached only in an interactive run …; an unattended run states its choice in the prompt" — a model running under claude -p reads that as permission to skip the question and silently pick a default, so the explore/skip choice never reaches the user (observed consistently in awos-qa e2e runs). Since #141 the deliverable Write no longer waits on any answer, asking is free in every mode: replace the sentence with an explicit ask-always rule, an unattended-safe default (Yes, explore), and pin the exact option labels. Claude-Session: https://claude.ai/code/session_01D56dVJjUsoRYEUnxcx3zsH
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The silent-prompt brownfield branch of
commands/product.mdended with "This question is reached only in an interactive run whose prompt expressed no preference; an unattended run states its choice in the prompt." A model running underclaude -preads that as permission to skip the question and silently pick a default — observed consistently in awos-qa e2e runs (0/3 asked at effort medium, 0/1 at high): the explore/skip choice from #137 never reaches the user.Since #141 the deliverable Write no longer waits on any answer, so asking is free in every mode. This replaces the sentence with:
Validated with awos-qa:
product-brownfield-offers-skipandproduct-brownfield-declines-skips-explorationgreen 2× in a row unattended against this branch (they fail against current main); companion QA-side changes in provectus/awos-qa#34.Draft — opened from the awos-qa e2e work; review wording before merging.
🤖 Generated with Claude Code
https://claude.ai/code/session_01D56dVJjUsoRYEUnxcx3zsH