Skip to content

Remove upstream-only GitHub workflows from fork#10

Merged
cedretaber merged 2 commits into
java_extractionfrom
chore/remove-upstream-workflows
Jul 2, 2026
Merged

Remove upstream-only GitHub workflows from fork#10
cedretaber merged 2 commits into
java_extractionfrom
chore/remove-upstream-workflows

Conversation

@cedretaber

Copy link
Copy Markdown

目的

この fork は Java extraction 開発のためのものですが、上流 Rocq から継承した2つの GitHub Actions ワークフローがこの fork では不要なため削除します。

変更内容

ファイル 削除理由
check-conflicts.yml on: [push] で毎 push 起動し、コンフリクトした PR に needs: rebase ラベルを付ける上流の PR 運用自動化。この fork には無関係で、毎 push に Actions 分を消費する。
stale.yml if: github.repository_owner == 'rocq-prover' でガードされており、この fork(owner = proof-ninja)では既に不活性。掃除のため削除。

ci-github.yml残します — Rocq をビルドして test-suite を実行し、その中に Java extraction の scripted test(misc/java-extraction.sh)が含まれるためです。

確認

この PR の push で ci-github.yml が起動し、macOS / Linux ジョブの test-suite misc サブシステムで java-extraction.sh が実行されることを確認します。削除した2ワークフローは走らないはずです。

🤖 Generated with Claude Code

This fork exists for Java extraction development, but two workflows were
inherited from upstream Rocq and serve no purpose here:

- check-conflicts.yml: runs on every push to label conflicting PRs
  ("needs: rebase") — upstream PR-flow automation irrelevant to this fork,
  and it consumes Actions minutes on each push.
- stale.yml: guarded by `github.repository_owner == 'rocq-prover'`, so it
  is already inert on this fork; removed for tidiness.

ci-github.yml is kept: it builds Rocq and runs the test-suite, which now
includes the Java extraction scripted tests (misc/java-extraction.sh).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@hiroshi-cl hiroshi-cl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいね

Two pre-existing failures surfaced once CI was enabled on the fork; neither
is related to the Java extraction work. Both are fixed by matching upstream
(rocq-prover/rocq) rather than suppressing symptoms.

- Linux `output/` extraction tests (EmptyExtraction.v, bug7348.v) failed
  because OCaml 5.5 makes ocamlfind print
  "[WARNING] Cannot read directory ../stublibs which is mentioned in ld.conf"
  during `Extraction TestCompile`, and that stderr line leaks into the
  captured test output, which is diffed verbatim against the .out fixtures.
  This is exactly the issue upstream fixed in 7d09774 ("github actions
  linux job use ocaml 5.4 to avoid warning with 5.5"): our `ocaml: 5`
  resolves to 5.5. Pin the Linux job to `ocaml: 5.4` to match upstream and
  avoid the warning at the source (no test-suite filter needed).

- Windows job failed at the Build step with "Extension coq was deleted in
  the 3.24 version of the dune language". Upstream's Windows job passes
  because upstream master has migrated off the deprecated dune `coq`
  extension; this fork predates that migration. Windows also disables the
  `misc` subsystem, so it never runs the Java extraction tests. Drop the
  Windows matrix entry rather than backport the dune migration; this fork
  targets Java extraction on Linux/macOS.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@cedretaber
cedretaber force-pushed the chore/remove-upstream-workflows branch from 58b838c to 0e158a1 Compare July 2, 2026 13:03
- name: Linux (latest OCaml)
os: ubuntu-latest
ocaml: 5
ocaml: 5.4

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cedretaber
cedretaber merged commit 6814591 into java_extraction Jul 2, 2026
4 checks passed
@cedretaber
cedretaber deleted the chore/remove-upstream-workflows branch July 2, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants