Make pdd checkup --pr rerun when PR head advances mid-checkup#1121
Open
prompt-driven-github[bot] wants to merge 1 commit into
Open
Make pdd checkup --pr rerun when PR head advances mid-checkup#1121prompt-driven-github[bot] wants to merge 1 commit into
prompt-driven-github[bot] wants to merge 1 commit into
Conversation
- Capture PR head SHA at start of PR-mode checkup. - Before Step 7 and final push, re-fetch remote PR head and compare. - If head advanced and local fix can rebase cleanly, keep rebased path and rerun verifier. - If rebase conflicts or head advanced before fix, discard stale worktree and rerun full checkup (bounded to 2 reruns). - Implement PRHeadAdvancedError and retry logic in agentic_checkup_orchestrator.py and checkup_review_loop.py. - Update prompts to support the new rebase_conflicted and pr_head_refreshes_count fields. - Update README and CHANGELOG with the new behavior. Issue: #1116
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pdd checkup --prcan still fail after completing the full checkup loop when the PR branch advances while the run is in progress and the generated local fix commit conflicts with the newer remote PR head.Solution
Implemented a PR-head freshness lease for
pdd checkup --pr:_commit_and_push_if_changedattempts a clean rebase.MAX_PR_HEAD_REFRESHES = 2.--no-fixmode.checkup_review_loop.Fixes #1116