Skip to content

config: guard against nil oauth2 credential in RoundTrip #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roidelapluie merged 3 commits into from
Apr 15, 2026
Merged

config: guard against nil oauth2 credential in RoundTrip #897

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81c6c6c
config: guard against nil oauth2 credential in RoundTrip
alliasgher Apr 13, 2026
974978e
config: simplify comments per review feedback
alliasgher Apr 15, 2026
0646baa
Merge branch 'main' into fix-oauth2-nil-credential-panic
alliasgher Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions config/http_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,12 @@ func (rt *oauth2RoundTripper) RoundTrip(req *http.Request) (*http.Response, erro
needsInit bool
)

// This should not happen when config goes through the normal Prometheus
// validation path, but guard against a nil credential to avoid a panic.
if rt.oauthCredential == nil {
return nil, errors.New("oauth2 client secret is required")
}

rt.mtx.RLock()
secret = rt.lastSecret
needsInit = rt.lastRT.Source == nil
Expand Down
Loading