Retract v1.20.3 - #832
Merged
Merged
Conversation
roidelapluie
force-pushed
the
retract
branch
2 times, most recently
from
September 3, 2025 14:48
2ccc985 to
5a8076c
Compare
ArthurSens
reviewed
Sep 3, 2025
Comment on lines
+40
to
+78
| retract ( | ||
| v1.20.3 // Tag pushed accidentally, see https://github.com/prometheus/common/issues/831 | ||
| v0.50.0 // Critical bug in counter suffixes, please read issue https://github.com/prometheus/common/issues/605 | ||
| ) |
Member
There was a problem hiding this comment.
Looks like tons of other tags were pushed accidentally. Once we retract 1.20.3, will 1.20.2 become the latest one?
roidelapluie
force-pushed
the
retract
branch
from
September 3, 2025 15:19
5a8076c to
e7b7cfb
Compare
Member
Author
|
I've ran |
roidelapluie
force-pushed
the
retract
branch
from
September 3, 2025 15:22
e7b7cfb to
76b966b
Compare
Fixes prometheus#831 Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
roidelapluie
force-pushed
the
retract
branch
from
September 3, 2025 15:22
76b966b to
e120453
Compare
Member
Author
|
Once merged, it is required to tag and push a v1.20.99 (which will be retracted directly) |
Member
|
I guess if we ever want to make v1, we'll need to start with v1.21.0. 😭 |
SuperQ
approved these changes
Sep 3, 2025
Member
Author
$ GOPROXY=https://proxy.golang.org GO111MODULE=on go get github.com/prometheus/common@v1.20.99
go: downloading github.com/prometheus/common v1.20.99
go: downloading github.com/stretchr/testify v1.11.1
go: downloading golang.org/x/crypto v0.41.0
go: downloading golang.org/x/sys v0.35.0
go: downloading google.golang.org/protobuf v1.36.8
go: downloading golang.org/x/tools v0.35.0
go: downloading golang.org/x/net v0.43.0
go: downloading golang.org/x/text v0.28.0
go: downloading golang.org/x/term v0.34.0
go: warning: github.com/prometheus/common@v1.20.99: retracted by module author: This tag is needed to retract accidental tags below, but is retracted directly.
go: to switch to the latest unretracted version, run:
go get github.com/prometheus/common@latest
go: upgraded github.com/prometheus/common v0.65.1-0.20250703115700-7f8b2a0d32d3 => v1.20.99
go: upgraded github.com/stretchr/testify v1.10.0 => v1.11.1
go: upgraded golang.org/x/crypto v0.39.0 => v0.41.0
go: upgraded golang.org/x/mod v0.25.0 => v0.26.0
go: upgraded golang.org/x/net v0.41.0 => v0.43.0
go: upgraded golang.org/x/sync v0.15.0 => v0.16.0
go: upgraded golang.org/x/sys v0.33.0 => v0.35.0
go: upgraded golang.org/x/term v0.32.0 => v0.34.0
go: upgraded golang.org/x/text v0.26.0 => v0.28.0
go: upgraded golang.org/x/tools v0.34.0 => v0.35.0
go: upgraded google.golang.org/protobuf v1.36.6 => v1.36.8
$ go get github.com/prometheus/common@latest
go: downloading github.com/prometheus/common v0.66.0
go: downgraded github.com/prometheus/common v1.20.99 => v0.66.0 |
Not with the retracted version, IMO. You just have to skip it. (And not forget to skip it :D ) Edit: ok, now I see the rich list of retracted version 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #831