Skip to content

Retract v1.20.3 - #832

Merged
roidelapluie merged 1 commit into
prometheus:mainfrom
roidelapluie:retract
Sep 3, 2025
Merged

Retract v1.20.3#832
roidelapluie merged 1 commit into
prometheus:mainfrom
roidelapluie:retract

Conversation

@roidelapluie

Copy link
Copy Markdown
Member

Fixes #831

@roidelapluie
roidelapluie requested review from SuperQ and ywwg September 3, 2025 14:46
@roidelapluie
roidelapluie force-pushed the retract branch 2 times, most recently from 2ccc985 to 5a8076c Compare September 3, 2025 14:48
Comment thread go.mod
Comment on lines +40 to +78
retract (
v1.20.3 // Tag pushed accidentally, see https://github.com/prometheus/common/issues/831
v0.50.0 // Critical bug in counter suffixes, please read issue https://github.com/prometheus/common/issues/605
)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tons of other tags were pushed accidentally. Once we retract 1.20.3, will 1.20.2 become the latest one?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

@roidelapluie

Copy link
Copy Markdown
Member Author

I've ran for v in $(curl https://proxy.golang.org/github.com/prometheus/common/@v/list|grep ^v1|sort -V); do go mod edit -retract=$v; done

Fixes prometheus#831

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
@roidelapluie

Copy link
Copy Markdown
Member Author

Once merged, it is required to tag and push a v1.20.99 (which will be retracted directly)

@SuperQ

SuperQ commented Sep 3, 2025

Copy link
Copy Markdown
Member

I guess if we ever want to make v1, we'll need to start with v1.21.0. 😭

@roidelapluie
roidelapluie merged commit 4c2f9e7 into prometheus:main Sep 3, 2025
7 checks passed
@roidelapluie

Copy link
Copy Markdown
Member Author
$ GOPROXY=https://proxy.golang.org GO111MODULE=on go get github.com/prometheus/common@v1.20.99
go: downloading github.com/prometheus/common v1.20.99
go: downloading github.com/stretchr/testify v1.11.1
go: downloading golang.org/x/crypto v0.41.0
go: downloading golang.org/x/sys v0.35.0
go: downloading google.golang.org/protobuf v1.36.8
go: downloading golang.org/x/tools v0.35.0
go: downloading golang.org/x/net v0.43.0
go: downloading golang.org/x/text v0.28.0
go: downloading golang.org/x/term v0.34.0
go: warning: github.com/prometheus/common@v1.20.99: retracted by module author: This tag is needed to retract accidental tags below, but is retracted directly.
go: to switch to the latest unretracted version, run:
        go get github.com/prometheus/common@latest
go: upgraded github.com/prometheus/common v0.65.1-0.20250703115700-7f8b2a0d32d3 => v1.20.99
go: upgraded github.com/stretchr/testify v1.10.0 => v1.11.1
go: upgraded golang.org/x/crypto v0.39.0 => v0.41.0
go: upgraded golang.org/x/mod v0.25.0 => v0.26.0
go: upgraded golang.org/x/net v0.41.0 => v0.43.0
go: upgraded golang.org/x/sync v0.15.0 => v0.16.0
go: upgraded golang.org/x/sys v0.33.0 => v0.35.0
go: upgraded golang.org/x/term v0.32.0 => v0.34.0
go: upgraded golang.org/x/text v0.26.0 => v0.28.0
go: upgraded golang.org/x/tools v0.34.0 => v0.35.0
go: upgraded google.golang.org/protobuf v1.36.6 => v1.36.8

$ go get github.com/prometheus/common@latest
go: downloading github.com/prometheus/common v0.66.0
go: downgraded github.com/prometheus/common v1.20.99 => v0.66.0

@prochac

prochac commented Sep 3, 2025

Copy link
Copy Markdown

I guess if we ever want to make v1, we'll need to start with v1.21.0. 😭

Not with the retracted version, IMO. You just have to skip it. (And not forget to skip it :D )
v1.20.0, ... v1.20.2, and v1.20.4

Edit: ok, now I see the rich list of retracted version 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strange tag behaviour on v1.20.3

4 participants