[prometheus-node-exporter] support digest and full image refs in image.tag - #7187
Open
maichouni-mitek wants to merge 3 commits into
Open
Conversation
Strip digest suffixes from image.tag before feature-gating with semverCompare so standard OCI references (tag@sha256:...) work. Values.version and Chart.AppVersion behavior are unchanged. Fixes prometheus-community#3589 Signed-off-by: MEHDI AICHOUNI <maichouni@miteksystems.com>
Handle registry/repository:tag[@digest] in image.tag for feature gates and image rendering so install with a full pinned ref succeeds. Signed-off-by: MEHDI AICHOUNI <maichouni@miteksystems.com>
maichouni-mitek
changed the title
maichouni-mitek
marked this pull request as ready for review
August 13, 2026 11:37
maichouni-mitek
requested review from
gianrubio,
zanhsieh and
zeritti
as code owners
August 13, 2026 11:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
semverComparewas applied toimage.tagas-is. Valid OCI forms such astag@sha256:…and full refs likeregistry/repository:tag@sha256:…are not plain semver, so templating fails withinvalid semantic version.This PR:
prometheus-node-exporter.appSemverto normalize those forms (and preferValues.version) before the>=1.4.0udev feature gateimage.tagvalues containing/as a full image reference so installs do not double-prefix registry/repositoryversion:override4.56.1→4.56.2Which issue this PR fixes
Special notes for your reviewer
Preferred pinning remains
image.registry/image.repository/image.tagplusimage.digest. Full refs inimage.tagare supported for compatibility with the #3589 reproduction and similar tooling.Checklist
[prometheus-couchdb-exporter])