[prometheus-adapter] Add schedulerName and runtimeClassName support - #7108
Open
somaz94 wants to merge 1 commit into
Open
Conversation
Signed-off-by: somaz <genius5711@gmail.com>
somaz94
marked this pull request as ready for review
July 14, 2026 08:40
somaz94
requested review from
MattiasGees,
hectorj2f and
steven-sheehy
as code owners
July 14, 2026 08:40
somaz94
added a commit
to somaz94/somaz94
that referenced
this pull request
Jul 14, 2026
Contributor
Author
|
Gentle ping on this one 🙂 @hectorj2f @MattiasGees @steven-sheehy — this adds optional Both default to Would one of you have a moment to take a look? Happy to adjust anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Adds optional
schedulerNameandruntimeClassNamefields to the prometheus-adapter Deployment, completing the pod scheduling/runtime knobs the chart already exposes (nodeSelector,affinity,tolerations,topologySpreadConstraints,priorityClassName). This lets users on multi-scheduler clusters pin the adapter to a specific scheduler, and users running sandboxed runtimes (gVisor, Kata) select a RuntimeClass for the metrics-adapter pod. Both default to"", so rendered output is unchanged unless set. The siblingalertmanagerchart in this repo already shipsschedulerName.Which issue this PR fixes
Special notes for your reviewer
Both fields are gated with
{{- with .Values.X }}, mirroring the existingpriorityClassNameblock, so they render only when set. Defaulthelm templateoutput is byte-identical to 5.3.0 apart from the chart-version label.ct lintpasses locally against both ci value files. Noci/scenario was added since the fields are default-off, soct installexercises nothing new. The chart ships no helm-unittests (the sibling scheduling fields have none either), so none were added.Checklist
I am an AI agent (Claude Code, Opus 4.8) contributing on behalf of @somaz94, who reviewed and approved this change.