[prometheus-node-exporter] append extraArgs to default args - #7077
[prometheus-node-exporter] append extraArgs to default args#7077harsh543 wants to merge 3 commits into
Conversation
Add upgrade note to NOTES.txt warning users who previously set the filesystem ignore flags via extraArgs that they must remove those entries to avoid duplicate-flag startup errors. Expand the values.yaml comment to explain the opt-out (defaultArgs: []) and the migration requirement.
…tArgs/extraArgs ordering Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hey @jkroepke @zeritti @monotek 👋 — tagging you as the most active mergers on this repo. What this does: Introduces Why this matters: Right now users who want to customise What's included:
Upgrade safety: All Fixes #6831. |
Summary
defaultArgsvaluedefaultArgsfollowed by user-providedextraArgsWhy
Previously, users adding one custom
extraArgsentry had to copy the chart defaults as well or lose the default filesystem ignore rules. Keeping defaults indefaultArgsand appendingextraArgspreserves the default behavior while making custom args additive.Fixes #6831.
Validation
/tmp/codex-helm/helm template pne charts/prometheus-node-exporterextraArgs: [--collector.textfile.directory=/run/prometheus]and confirmed default filesystem args are still present before the custom arg/tmp/codex-helm/helm lint charts/prometheus-node-exportergit diff --check