Derive object storage buckets from namespace#54
Open
geier wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces manual MinIO bucket placeholders with namespace-derived <namespace>-data defaults across notebooks, pipeline scripts, and RStudio examples, and updates docs/comments to use generic "object storage" terminology while keeping the mc CLI alias usage.
Changes:
- Read the Kubernetes service account namespace at runtime and derive
s3_bucket = f"{namespace}-data"in Python notebooks/scripts and R examples; strip whitespace from the namespace value. - Rename pipeline/component parameters from
minio_*_data_pathto*_data_pathand pull the cluster S3 endpoint fromS3_ENDPOINT(replacing the hardcodedhttp://minio.minio). - Rephrase MinIO-specific docs/comments to generic object storage terminology (READMEs, notebook markdown, docstrings).
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Generic phrasing for self-hosted S3-compatible storage instead of MinIO. |
| serving/minimal-s3-model/README.md | Generic object storage wording. |
| serving/minimal-s3-model/minimal-s3-model.ipynb | Strip namespace; rename inference service; object-storage wording. |
| rstudio/iris-classification/README.md, .r | Derive bucket from namespace; update wording. |
| rstudio/mobile-price-classification/README.md, .r | Same pattern as iris example. |
| pipelines/lightweight-python-package/submit-cluster.py | Derive bucket from namespace; rename pipeline args. |
| pipelines/lightweight-python-package/pipeline.py | Rename component/pipeline params; use S3_ENDPOINT env. |
| pipelines/lightweight-python-package/src/.../read_data.py | Rename params and update docstring. |
| pipelines/lightweight-python-package/README.md | Update workflow notes for default bucket. |
| pipelines/lightweight-components/mobile-price-classifications.ipynb | Derive bucket from namespace; rename params; use S3_ENDPOINT. |
| notebooks/mobile-price-classification/mobile-price-classifications.ipynb | Derive bucket from namespace; rename data path variables. |
| mlflow/mobile-price-classification/mlflow-mobile-price-classification.ipynb | Same namespace/param updates plus S3_ENDPOINT usage. |
| mlflow/mlflow-kfp-example.ipynb | Docstring wording update only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<namespace>-databucket.mcCLI alias where it is required for artifact download commands.Related
Tests
python3 -m json.tool serving/minimal-s3-model/minimal-s3-model.ipynbpython3 -m json.tool notebooks/mobile-price-classification/mobile-price-classifications.ipynbpython3 -m json.tool pipelines/lightweight-components/mobile-price-classifications.ipynbpython3 -m json.tool mlflow/mobile-price-classification/mlflow-mobile-price-classification.ipynbpython3 -m json.tool mlflow/mlflow-kfp-example.ipynbpython3 -m py_compile pipelines/lightweight-python-package/submit-cluster.py pipelines/lightweight-python-package/pipeline.py pipelines/lightweight-python-package/src/mobile_price_classification/read_data.pygit grep -n -i minio -- .returns only the defaultmcCLI alias usage inpipelines/lightweight-components/mobile-price-classifications.ipynbgit diff --checkNotes
Rscriptis not installed in the local environment.