Skip to content

Derive object storage buckets from namespace#54

Open
geier wants to merge 3 commits into
mainfrom
derive-minio-buckets
Open

Derive object storage buckets from namespace#54
geier wants to merge 3 commits into
mainfrom
derive-minio-buckets

Conversation

@geier
Copy link
Copy Markdown
Contributor

@geier geier commented May 26, 2026

Summary

  • Derive default object storage bucket names from the current Kubernetes namespace across notebooks, pipeline submission, and RStudio examples.
  • Remove manual bucket placeholders and update docs to reference the default <namespace>-data bucket.
  • Replace product-specific storage wording with generic object storage terminology across tracked examples.
  • Keep the existing default mc CLI alias where it is required for artifact download commands.
  • Strip the namespace value in the KServe object storage example before using it in bucket names and internal URLs.

Related

  • prokube/dev-tracker#281

Tests

  • python3 -m json.tool serving/minimal-s3-model/minimal-s3-model.ipynb
  • python3 -m json.tool notebooks/mobile-price-classification/mobile-price-classifications.ipynb
  • python3 -m json.tool pipelines/lightweight-components/mobile-price-classifications.ipynb
  • python3 -m json.tool mlflow/mobile-price-classification/mlflow-mobile-price-classification.ipynb
  • python3 -m json.tool mlflow/mlflow-kfp-example.ipynb
  • python3 -m py_compile pipelines/lightweight-python-package/submit-cluster.py pipelines/lightweight-python-package/pipeline.py pipelines/lightweight-python-package/src/mobile_price_classification/read_data.py
  • git grep -n -i minio -- . returns only the default mc CLI alias usage in pipelines/lightweight-components/mobile-price-classifications.ipynb
  • git diff --check

Notes

  • R syntax parsing was not run because Rscript is not installed in the local environment.

@geier geier changed the title Derive MinIO buckets from namespace Derive object storage buckets from namespace May 26, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Replaces manual MinIO bucket placeholders with namespace-derived <namespace>-data defaults across notebooks, pipeline scripts, and RStudio examples, and updates docs/comments to use generic "object storage" terminology while keeping the mc CLI alias usage.

Changes:

  • Read the Kubernetes service account namespace at runtime and derive s3_bucket = f"{namespace}-data" in Python notebooks/scripts and R examples; strip whitespace from the namespace value.
  • Rename pipeline/component parameters from minio_*_data_path to *_data_path and pull the cluster S3 endpoint from S3_ENDPOINT (replacing the hardcoded http://minio.minio).
  • Rephrase MinIO-specific docs/comments to generic object storage terminology (READMEs, notebook markdown, docstrings).

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Generic phrasing for self-hosted S3-compatible storage instead of MinIO.
serving/minimal-s3-model/README.md Generic object storage wording.
serving/minimal-s3-model/minimal-s3-model.ipynb Strip namespace; rename inference service; object-storage wording.
rstudio/iris-classification/README.md, .r Derive bucket from namespace; update wording.
rstudio/mobile-price-classification/README.md, .r Same pattern as iris example.
pipelines/lightweight-python-package/submit-cluster.py Derive bucket from namespace; rename pipeline args.
pipelines/lightweight-python-package/pipeline.py Rename component/pipeline params; use S3_ENDPOINT env.
pipelines/lightweight-python-package/src/.../read_data.py Rename params and update docstring.
pipelines/lightweight-python-package/README.md Update workflow notes for default bucket.
pipelines/lightweight-components/mobile-price-classifications.ipynb Derive bucket from namespace; rename params; use S3_ENDPOINT.
notebooks/mobile-price-classification/mobile-price-classifications.ipynb Derive bucket from namespace; rename data path variables.
mlflow/mobile-price-classification/mlflow-mobile-price-classification.ipynb Same namespace/param updates plus S3_ENDPOINT usage.
mlflow/mlflow-kfp-example.ipynb Docstring wording update only.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@geier geier requested a review from tmvfb May 27, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants