Add fair lock policy to @Locked via @Locked.Policy - #4063
Open
vulinh64 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Lombok team,
This is my first contribution, and thank you for taking the time to review it.
This PR adds class-level lock fairness configuration through:
When present, Lombok generates fair locks for the class:
@Locked->new ReentrantLock(true)@Locked.Read/@Locked.Write-> a sharednew ReentrantReadWriteLock(true)By default,
ReentrantLockandReentrantReadWriteLockare non-fair, and Lombok’s existing behavior remains unchanged. The policy only affects locks generated by Lombok; explicitly named locks and user-declared lock fields are deliberately left untouched.With JDK 25 that fixed the pinned
synchronizedissue, the usage of@Lockedcan still be attractive with the optional fairness policy.The implementation includes javac and Eclipse support, transform tests for generated and named locks, and documentation/usage-example updates.
I would appreciate feedback on the API and implementation choices.