Reject ambiguous Builder class name collisions - #4052
Open
snowykte0426 wants to merge 2 commits into
Open
Conversation
Collaborator
|
@snowykte0426 Thanks for this contribution as well. Can you add your name to the AUTHORS file, so we are legally covered? In the meantime, we've promoted |
snowykte0426
force-pushed
the
bugfix/3857-builder-class-name-conflict
branch
from
August 7, 2026 00:28
f6c00af to
70451b9
Compare
Contributor
Author
|
Thanks, @rspilker! Added myself to AUTHORS. I also rebased onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@BuilderwhenbuilderClassNameresolves toBuilder, suggesting@lombok.Builderinstead@SuperBuilder/SuperBuilderFixes #3857.
Tests
JAVA_HOME=$(/usr/libexec/java_home -v 21) ant -noinput test.javacCurrentgit diff --checkJAVA_HOME=$(/usr/libexec/java_home -v 21) ant -noinput dist test.eclipse-202503confirms the new Builder/SuperBuilder cases pass; the target still fails later on existingecj-ValUndenotable.javamissing expected output.