Skip to content

Add NonNull annotations to test cases for testing annotation copying - #3589

Draft
burdoto wants to merge 1 commit into
projectlombok:masterfrom
burdoto:copy-annotations
Draft

Add NonNull annotations to test cases for testing annotation copying#3589
burdoto wants to merge 1 commit into
projectlombok:masterfrom
burdoto:copy-annotations

Conversation

@burdoto

@burdoto burdoto commented Jan 17, 2024

Copy link
Copy Markdown

Closes #3318

This PR introduces @NonNull annotations as part of @Data and @Value classes' fields in order to be copied from fields to constructors, getters and setters as requested in #3318 (comment).

@burdoto

burdoto commented Jan 17, 2024

Copy link
Copy Markdown
Author

After writing and testing the modified Test case, I noticed that this does in fact function with the @lombok.NonNull annotation.
The reported issue applies to external annotations such as org.intellij.lang.annotations.Language (as reported in #3318 (comment)) that are affected. However, for the test case, as a new contributor, I dont have enough project insight to correctly introduce external annotations to this test case (let alone since maven fails to import the whole project).

@burdoto
burdoto marked this pull request as draft January 17, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Custom nullable annotations are not copied to constructors and methods for Value/Data classes

1 participant