fix(fingerprints): prevent jQuery false positive from plugin URLs#161
Open
yutasuzuki-0206 wants to merge 1 commit into
Open
fix(fingerprints): prevent jQuery false positive from plugin URLs#161yutasuzuki-0206 wants to merge 1 commit into
yutasuzuki-0206 wants to merge 1 commit into
Conversation
The first scriptSrc pattern for jQuery (`/(\d+\.\d+\.\d+)/jquery[/.-][^u]`) incorrectly matches jQuery plugin URLs such as: `jquery-cookie/1.4.1/jquery.cookie.min.js` This causes the plugin's version (1.4.1) to be reported as the jQuery version, leading to false positive CVE detections. Changed the pattern to require `jquery.js` or `jquery.min.js` specifically, preventing matches on plugin filenames like `jquery.cookie.js`, `jquery-ui.js`, or `jquery.fancybox.js`. Before: `/(\\d+\\.\\d+\\.\\d+)/jquery[/.-][^u]` After: `/(\\d+\\.\\d+\\.\\d+)/jquery(?:\\.min)?\\.js` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Neo - PR Security ReviewCaution Neo couldn't finish analyzing this pull request during this run. Please run the review again. Comment |
|
@yutasuzuki-0206 I think you are trying to change an autogenerated file. The actual definition is here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first
scriptSrcpattern for jQuery incorrectly matches jQuery plugin URLs, causing false version detection.Problem
The current pattern:
Matches plugin URLs like:
The path
/1.4.1/jquery.csatisfies[/.-][^u], extracting1.4.1as the jQuery version — even though this is the jquery-cookie plugin version, not jQuery itself.This leads to incorrect CVE matches (e.g., 7 false positive vulnerabilities including KEV-listed CVE-2020-11023) on sites that actually run jQuery 3.7.0+.
Fix
Changed the pattern to require
jquery.jsorjquery.min.jsspecifically:This prevents matches on plugin filenames like
jquery.cookie.js,jquery-ui.js, orjquery.fancybox.js.Test cases
/3.7.0/jquery.min.js/3.6.0/jquery.js/jquery-cookie/1.4.1/jquery.cookie.min.js/jquery-ui/1.13.2/jquery-ui.min.js/1.0.0/jquery.fancybox.min.jsAll existing tests pass.