Miscellaneous Improvements From My Work On A CMake Port#202
Merged
Conversation
I also relocated the move to/from spr/msr macros to the header because they might be useful in other places (like they are in my downstream cmake fork).
These non-void functions that return nothing are messing with my CMake port. Let's decompile them!
Report for G98E01_PIKIDEMO (0971b5c - b72c215)No changesReport for GPIE01_00 (0971b5c - b72c215)No changesReport for G98P01_PIKIDEMO (0971b5c - b72c215)No changesReport for GPIP01_00 (0971b5c - b72c215)No changesReport for GPIE01_01 (0971b5c - b72c215)No changesReport for DPIJ01_PIKIDEMO (0971b5c - b72c215)No changesReport for GPIJ01_02 (0971b5c - b72c215)No changesReport for GPIJ01_01 (0971b5c - b72c215)No changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could spend a lifetime fixing the little things that are wrong or missing in this codebase.