Fix kernel hashes build failure#5129
Closed
CookieComputing wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Kevin Hui <kevinhui@meta.com>
Signed-off-by: Kevin Hui <kevinhui@meta.com>
Collaborator
conradgrobler
left a comment
There was a problem hiding this comment.
Thanks! Could you please run just format? The linter is failing on the README change.
Contributor
Author
|
Thanks! Just formatted it |
Collaborator
|
Imported as d1fb4aa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was trying to build stage0 with the new
sev_kernel_hashesfeature introduced in 6fe1a11, I noticed that I was getting build failures:This is replicable with the following changes:
After this PR, those build failures go away:
I also took the liberty to add a note to
stage0_bin/READMEto add a comment about kernel hashes