Share Chatterbox API across Olares users#15
Merged
Conversation
Convert the canonical Olares package into the v2 shared-app shape used by current Beclab examples: an admin-installed shared server subchart plus a per-user proxy subchart that preserves a normal user endpoint. The manifest now exposes a hidden shared entrance for internal app-to-app calls and keeps a user-space API entrance for installed users. Constraint: Follow Olares shared app pattern from local ComfyUI and Whisper examples Rejected: Only add sharedEntrances to the existing single chart | would still deploy one GPU API instance per user instead of a shared server Rejected: Update chart and chart-v2 lanes | README identifies olares/chatterboxapi as the canonical current package and the other lanes use different app IDs Confidence: medium Scope-risk: moderate Directive: Keep the user proxy pointed at the shared server namespace unless the Olares subchart namespace convention changes Tested: Ruby YAML parse of rendered admin/member manifest and chart templates; kubectl create --dry-run=client --validate=ignore for rendered Kubernetes resources; git diff --check Not-tested: helm template/package because helm is not installed in this environment; live Olares install
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 463119cd92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merging master keeps the shared Olares app work on top of the frontend and chart version updates already landed upstream. The README conflict is resolved by preserving upstream API docs and adding Olares packaging as a separate section; chart metadata follows the current 2.30.0 release. Constraint: PR #15 targets master after upstream version bumps through 2.30.0 Rejected: Keep branch chart version 2.2.0 | would regress package metadata behind current base Confidence: high Scope-risk: narrow Directive: Keep shared-app Olares notes separate from upstream API usage examples Tested: git diff --check origin/master; conflict-marker scan; python -m compileall -q app main.py start.py; chart metadata sanity script Not-tested: helm lint because helm is not installed in this environment
Master advanced to the 2.31.0 release while PR #15 was being updated. This merge keeps the shared Olares app branch on the current base and carries the version bump through the app chart and manifest while preserving the shared entrance layout. Constraint: PR #15 must merge cleanly into the current master tip Rejected: Leave chart metadata at 2.30.0 | would immediately conflict with the current release bump Confidence: high Scope-risk: narrow Directive: Future release bumps must update both the root Olares chart and manifest metadata Tested: git diff --check origin/master; conflict-marker scan; python -m compileall -q app main.py start.py; version/shared manifest sanity script Not-tested: helm lint because helm is not installed in this environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Not tested