Add the belongs to association - #47
Conversation
|
Changes Unknown when pulling fcd5ac4 on xiangge:associations into ** on product-definition-center:master**. |
Add the belongs to association
| @@ -0,0 +1,40 @@ | |||
| module PDC::Resource | |||
There was a problem hiding this comment.
What is this latest file for?
There was a problem hiding this comment.
Put fake file, sorry about that.
| ap releases | ||
|
|
||
| released_files = PDC::V1::ReleasedFile.all!.to_a | ||
| ap releases |
There was a problem hiding this comment.
This change is not relevant to belongs_to.
There was a problem hiding this comment.
Aha, the latest change was merged in another patch, after roll back the previous changes in this pr, the codes came to old one, will change back.
| Exclude: | ||
| - lib/pdc/config.rb | ||
|
|
||
| Metrics/ModuleLength: |
There was a problem hiding this comment.
Is this changing the ordering?
If so, we can make it in another patch.
There was a problem hiding this comment.
This is just for resolving the conflict, thanks for reminding that, will change back
simozhan
left a comment
simozhan
left a comment
There was a problem hiding this comment.
Will continue review in detail.
4667fe3 to
0717ecb
Compare
|
Sorry for commit several time after your comments, correct several time about the blank line and space in ".rubocop.yml" |
|
Sorry for the slow review. It seems like it would better to squash this down into a few commits since the later commits seem like fixups and design changes. Do you want to try cleaning up the history and repushing? This should make review easier also. |
5 participants
Add the belongs to association.
As this our ruby gem is just used for selecting data. So not add the new/build association part.
Use can add the association in the class codes and also add a foreign_key method with the foreign key attribute return.