Skip to content

Advertise NIP-51 and document/test Marmot KeyPackage relay support#158

Merged
kwsantiago merged 3 commits into
mainfrom
feat/kind10051-keypackage-relays
Jul 14, 2026
Merged

Advertise NIP-51 and document/test Marmot KeyPackage relay support#158
kwsantiago merged 3 commits into
mainfrom
feat/kind10051-keypackage-relays

Conversation

@wksantiago

@wksantiago wksantiago commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Document and test Marmot/MLS (Haven, WhiteNoise) compatibility. Wisp's generic NIP-16/NIP-33 handling already stores and serves the relevant kinds; this PR makes that support explicit and regression-tested, and advertises NIP-51 in the NIP-11 document.

Changes

  • NIP-11: add 51 to supported_nips (kind 10050 DM-relays list is a NIP-51 standard list).
  • README: note Marmot/MLS compatibility — kinds 10050 (DM/inbox relays, replaceable), 10051 (KeyPackage relays, replaceable), 30443 (KeyPackage, addressable) / legacy 443, and 1059 gift wraps are all stored and served generically, so Marmot clients work without extra setup.
  • Integration tests: replaceable latest-wins for kinds 10050 and 10051, and addressable replace/keep-by-d-tag for kind 30443.

NIP-17

NIP-17 is intentionally not advertised. It requires relays to serve kind:1059 gift wraps only to the p-tagged recipient (via NIP-42 AUTH); Wisp currently serves gift wraps generically with no per-recipient gating, so advertising NIP-17 would overstate the DM-metadata privacy guarantee. The README documents this and points operators to auth_required if they want to restrict kind 1059 reads. Recipient-scoped gating can be added later as a prerequisite to advertising NIP-17.

Verification

Full protocol integration suite passes end-to-end against a live relay (45/45), including the new kind 10050/10051/30443 assertions. zig build and zig build test pass.

Closes #156

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@wksantiago, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3482ddcf-470a-47b8-be42-239ce437e9c4

📥 Commits

Reviewing files that changed from the base of the PR and between 941f501 and 0f1bda2.

📒 Files selected for processing (3)
  • README.md
  • src/nip11.zig
  • tests/integration.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/kind10051-keypackage-relays

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wksantiago wksantiago self-assigned this Jul 14, 2026
@wksantiago

Copy link
Copy Markdown
Contributor Author

Merge order: #157 should merge first, then this PR (#158). #158 is stacked on #157 and will narrow to its single kind-10051 commit once #157 lands.

@kwsantiago kwsantiago changed the title Add kind 10051 replaceable test Advertise NIP-51 and document/test Marmot KeyPackage relay support Jul 14, 2026
@kwsantiago
kwsantiago merged commit 2741888 into main Jul 14, 2026
3 checks passed
@kwsantiago
kwsantiago deleted the feat/kind10051-keypackage-relays branch July 14, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document kind 10051 (Marmot KeyPackage Relays List) support — Haven/Marmot compat

2 participants