Skip to content

Update wisp to v0.5.1 (crash-safe storage, spider + per-IP fixes)#7

Merged
kwsantiago merged 1 commit into
masterfrom
chore/update-wisp-0.5.1
Jun 17, 2026
Merged

Update wisp to v0.5.1 (crash-safe storage, spider + per-IP fixes)#7
kwsantiago merged 1 commit into
masterfrom
chore/update-wisp-0.5.1

Conversation

@kwsantiago

@kwsantiago kwsantiago commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Brings the package to wisp v0.5.1 and fixes the two issues found testing on StartOS.

(PR #4 merged at v0.5.0 two days ago; the v0.5.1 + per-IP work was force-pushed to that already-merged branch and never reached master, so this is a fresh PR off current master.)

Changes

  • Dockerfile: WISP_VERSION v0.5.0 → v0.5.1, WISP_COMMIT 5d5d2fd... (commit-guarded).
  • startos/versions/current.ts: 0.5.0:00.5.1:0, release notes covering crash-safe storage, the Spider feed-freeze fix, and the per-IP change.
  • startos/init/seedFiles.ts: seed a high max_connections_per_ip (only when the operator has not set one) so the relay is not capped at 10 connections behind the StartOS reverse proxy, which collapses every client to the proxy's single source IP. Matches how nostr-rs-relay and strfry are packaged (neither limits per IP); global max_connections + the event/query rate limits still protect against abuse. Supersedes Seed trust_proxy=true so per-IP limit works behind StartOS proxy #6 (the trust_proxy / X-Forwarded-For approach, which relied on the unverified assumption that the StartOS ws proxy injects X-Forwarded-For).

What v0.5.1 brings users

  • Storage is crash-safe by default (durable, no corruption on power loss).
  • Spider keeps your feed current instead of freezing for hours after the initial sync.
  • The relay accepts more than 10 concurrent connections behind the StartOS proxy.

Closes #6.

Closes #5.

Summary by CodeRabbit

  • Bug Fixes

    • Fixed Spider feed freezing issue
    • Resolved connection capping problem behind reverse proxy
  • Chores

    • Updated to version 0.5.1
    • Enhanced crash-safe and durable storage capabilities

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 503c6a14-fe8f-4110-8a9e-b71d4e97425f

📥 Commits

Reviewing files that changed from the base of the PR and between a9c6ea7 and 7ad34b4.

📒 Files selected for processing (3)
  • Dockerfile
  • startos/init/seedFiles.ts
  • startos/versions/current.ts

Walkthrough

Upgrades the pinned WISP binary from v0.5.0 to v0.5.1 in the Dockerfile, adds conditional seeding of security.max_connections_per_ip = 100000 in seedFiles when the value is unset, and bumps the StartOS package version to 0.5.1:0 with updated release notes.

Changes

Wisp v0.5.1 Release

Layer / File(s) Summary
Conditional per-IP connection limit seeding
startos/init/seedFiles.ts
seedFiles now reads the existing wisp.toml and merges security.max_connections_per_ip: 100000 only when the field is undefined, instead of the previous unconditional empty merge. Subsequent operator-set values are preserved on re-init.
WISP binary and package version bumps
Dockerfile, startos/versions/current.ts
WISP_VERSION updated to v0.5.1 and WISP_COMMIT set to the matching SHA in the Dockerfile. current.ts advances the StartOS package version to 0.5.1:0 and replaces the release notes string.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • privkeyio/wisp-startos#4: Follows the same pattern of bumping the pinned WISP tag/commit in the Dockerfile and updating startos/versions/current.ts with release metadata for a new wisp version.

Poem

🐇 A hop from five-oh to five-one we go,
The proxy was hiding each IP, you know!
A hundred thousand connections now seeded,
No more TooManyPerIp — workaround unneeded.
The relay runs free, the SHA is pinned right,
This bunny ships fixes by candlelight! 🕯️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: upgrading wisp to v0.5.1 and addressing the specific issues (crash-safe storage, spider feed freezing, per-IP connection limit fixes).
Linked Issues check ✅ Passed The PR successfully addresses both linked issues by seeding a high max_connections_per_ip value in seedFiles.ts when unset, solving the per-IP connection capping problem identified in issues #5 and #6.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objectives: updating wisp version, adjusting per-IP connection limits, and documenting the improvements in release notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-wisp-0.5.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wksantiago

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kwsantiago
kwsantiago merged commit 68cb256 into master Jun 17, 2026
2 checks passed
@wksantiago
wksantiago deleted the chore/update-wisp-0.5.1 branch June 18, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Per-IP connection limit caps relay at 10 connections behind StartOS proxy

2 participants