Update wisp to v0.5.1 (crash-safe storage, spider + per-IP fixes)#7
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughUpgrades the pinned WISP binary from v0.5.0 to v0.5.1 in the Dockerfile, adds conditional seeding of ChangesWisp v0.5.1 Release
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Brings the package to wisp v0.5.1 and fixes the two issues found testing on StartOS.
(PR #4 merged at v0.5.0 two days ago; the v0.5.1 + per-IP work was force-pushed to that already-merged branch and never reached master, so this is a fresh PR off current master.)
Changes
WISP_VERSIONv0.5.0 → v0.5.1,WISP_COMMIT5d5d2fd...(commit-guarded).0.5.0:0→0.5.1:0, release notes covering crash-safe storage, the Spider feed-freeze fix, and the per-IP change.max_connections_per_ip(only when the operator has not set one) so the relay is not capped at 10 connections behind the StartOS reverse proxy, which collapses every client to the proxy's single source IP. Matches how nostr-rs-relay and strfry are packaged (neither limits per IP); globalmax_connections+ the event/query rate limits still protect against abuse. Supersedes Seed trust_proxy=true so per-IP limit works behind StartOS proxy #6 (the trust_proxy / X-Forwarded-For approach, which relied on the unverified assumption that the StartOS ws proxy injectsX-Forwarded-For).What v0.5.1 brings users
Closes #6.
Closes #5.
Summary by CodeRabbit
Bug Fixes
Chores