keep-nip46: disconnect client on connect_with setup-error path

[kwsantiago]

In Nip46Client::connect_with, the timeout arm disconnects the Client before returning, but the setup-error arm (Ok(Err(e)), reached when add_relay or subscribe fails within the timeout) returned the error while dropping the Client without disconnecting. nostr-sdk spawns background tasks per relay that Drop does not necessarily tear down, so a failed connect leaked relay connections/tasks.

Change

• Call client.disconnect().await on the setup-error arm before propagating, matching the timeout arm. Both error paths now tear down the client.

Verification

• cargo test -p keep-nip46: 167 passed. cargo clippy -p keep-nip46 --all-targets: clean.

[coderabbitai]

Warning

Review limit reached

@kwsantiago, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 54cc2fd4-c618-48c8-9cc8-1ac2f6fabb19

📥 Commits

Reviewing files that changed from the base of the PR and between 3075d3b and 9d8a2c9.

📒 Files selected for processing (1)

• keep-nip46/src/client.rs

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/nip46-client-disconnect-on-setup-error

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}